Use Bitcoin types everywhere

[KnowWhoami]

• While updating our rust-bitcoin dependency, we attempted to replace all primitive types with the alternative rust-bitcoin types in update bitcoin to v0.32 #182.
  But there are many places still left to apply these changes , thus created subtasks for them.

• Use Amount type for denoting Bitcoin amounts instead of plain u64.

  • Example:

    coinswap/src/protocol/contract.rs

    Line 57 in 57bf238

    pub fn calculate_coinswap_fee(

• Use FeeRate type for fee-rate.

• Use locktime::relative::LockTime for denoting relative locktime instead of u16.

• Use BlockHeight for denoting the height of a block.

[KnowWhoami]

IMO, I have covered all basic structs , though I will add new subtasks in case if found any.

[A-y-ush]

Hey @KnowWhoami I would like to work on this issue. Can I be assigned to it ?

[KnowWhoami]

Go ahead.
We will assign you once you come with your pr.

[Shash-Projects]

@KnowWhoami , Do we need to make these type changes across all the files ?

[mojoX911]

Yes this should be applied across all modules in the lib wherever applicable.

[Shash-Projects]

Can you please tell me whether the fee_rate is in satoshi per virtual byte (sat_per_vb) or per kilo virtual byte (sat_per_kvb) ?

[mojoX911]

sats_per_vb would be preferred.

[KnowWhoami]

Can you please tell me whether the fee_rate is in satoshi per virtual byte (sat_per_vb) or per kilo virtual byte (sat_per_kvb) ?

sats_per_vb would be preferred.

No, Rust-bitcoin have a dedicated struct FeeRate for representing fee rate in sat/(kilo weight unit).
Just use that struct instead.

[Shash-Projects]

Yes, but the FreeRate struct offers two methods: sat per vbyte and other sat per kilo vbyte. Should i go with per kilo vbyte?

[mojoX911]

Any one of them works. I would go for sat per vbyte as thats the defacto unit used in most places. And we will use that or our apps too.

[Shash-Projects]

Can you please review the pr#342 and notify the changes that need to be made ?

[KnowWhoami]

looking into #342

[Shash-Projects]

I think i can start working on this issue again. Should i open independent pr for updating types of amount, feeRate, locktime or just a single pr after making all the changes?

[KnowWhoami]

Single pr works.