Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to Export assessment to Excel #4434

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Conversation

randywoods
Copy link
Collaborator

🗣 Description

Fixed bug with unanswered assessments.
Also cleaned up and i18n the export dialog.
Maturity question text may come from the Security_Practice column instead of Question_Text.

💭 Motivation and context

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

Fixed bug with unanswered assessments.  Also cleaned up and i18n the export dialog.  Maturity question text may come from the Security_Practice column instead of Question_Text.
@LaddieZeigler LaddieZeigler merged commit c959e1a into develop Feb 12, 2025
4 checks passed
@LaddieZeigler LaddieZeigler deleted the feature/CSET-3017 branch February 12, 2025 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants