Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored Observation data gathering to support unassigned #4423

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

randywoods
Copy link
Collaborator

🗣 Description

The original code that generated the Observations Tear-Out Sheets report did not include "unassigned" Observations. For the new Excel export we needed to include all Observations. The Tear-Out Sheets report now also has an "Unassigned" sheet at the end for completeness.

💭 Motivation and context

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@LaddieZeigler LaddieZeigler merged commit 752571b into develop Feb 11, 2025
2 checks passed
@LaddieZeigler LaddieZeigler deleted the bug/CSET-3007 branch February 11, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants