Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralized AWWA URL into a service #4047

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Centralized AWWA URL into a service #4047

merged 1 commit into from
Sep 11, 2024

Conversation

randywoods
Copy link
Collaborator

The URL has changed since we hard coded it in a bunch of places. Now we only have one place to update if it changes in the future.

πŸ—£ Description

πŸ’­ Motivation and context

πŸ§ͺ Testing

βœ… Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

βœ… Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

βœ… Post-merge checklist

  • Create a release.

The URL has changed since we hard coded it in a bunch of places.  Now we only have one place to update if it changes in the future.
@jekuipers jekuipers merged commit b5fb9ca into develop Sep 11, 2024
2 checks passed
@jekuipers jekuipers deleted the awwa-email-fix branch September 11, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants