Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report refactor: Feat/cset 2813 #3997

Merged
merged 6 commits into from
Jul 31, 2024
Merged

Report refactor: Feat/cset 2813 #3997

merged 6 commits into from
Jul 31, 2024

Conversation

LaddieZeigler
Copy link
Contributor

Assessment reports now use all the same sub-component to display report links. Report links are saved in a json file and parsed out by sectionId.

🗣 Description

💭 Motivation and context

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@jekuipers jekuipers merged commit aeb0bad into develop Jul 31, 2024
2 checks passed
@jekuipers jekuipers deleted the feat/CSET-2813 branch July 31, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants