Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Code Editor Not Clearing After Import Submission #3727

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

Marcus-Goectau
Copy link
Member

🗣 Description

Looking at the code, it appears the intended behavior of the “import another module” button was to clear the form completely to prepare for an additional module import. However, the codeModel was not being properly reset, allowing for invalid JSON to be sent to the API on subsequent submissions. This has been fixed and a warning has been introduced next to the "import another module" button so it is clear that the code editor is reset after each submission.

💭 Motivation and context

bug/CSET-139

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@randywoods randywoods merged commit 16ed3c1 into develop Feb 6, 2024
4 checks passed
@randywoods randywoods deleted the bug/CSET-139 branch February 6, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants