Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: cset-2541 fix .NET warnings #3703

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Conversation

itsmostafa
Copy link
Collaborator

@itsmostafa itsmostafa commented Jan 17, 2024

Fix compile warnings due to .NET 8 upgrade

πŸ—£ Description

πŸ’­ Motivation and context

πŸ§ͺ Testing

tested locally

βœ… Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • All new and existing tests pass.

@itsmostafa itsmostafa changed the base branch from main to develop January 17, 2024 15:09
@itsmostafa itsmostafa marked this pull request as ready for review January 17, 2024 19:04
@itsmostafa itsmostafa self-assigned this Jan 22, 2024
@Marcus-Goectau Marcus-Goectau merged commit 8378fb7 into develop Jan 22, 2024
3 checks passed
@Marcus-Goectau Marcus-Goectau deleted the feature/cset-2541 branch January 22, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants