Remove kernel version check for LSM Resolve flag #3415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This condition was not necessary because in any case following code will return an error since it can not found the required hook. So this commit remove this check and add a specific case where the error should raise for LSM hooks only. Signed-off-by: Tristan d'Audibert <tristan.daudibert@orange.com>
ScriptSathi
commented
Feb 18, 2025
| @@ -123,6 +123,11 @@ func FindBtfFuncParamFromHook(hook string, argIndex int) (*btf.FuncParam, error) | |||
| } | |||
|
|
|||
| if err = spec.TypeByName(hook, &hookFn); err != nil { | |||
| if strings.HasPrefix(hook, "bpf_lsm_") { | |||
There was a problem hiding this comment.
I think it is acceptable to such a check instead of passing a boolean directly to the function. I wanted to keep the function resilient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the follow-up to this comment #3143 (comment)
In
genericlsm.gowe check the kernel version for the use of the Resolve flag. But it is not reliable because vendors may (like rhel) may have kernels with additional patches, but they are detected as lower than the required version.