Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tetragon: assorted fixes #3394

Merged
merged 5 commits into from
Feb 18, 2025
Merged

tetragon: assorted fixes #3394

merged 5 commits into from
Feb 18, 2025

Conversation

olsajiri
Copy link
Contributor

@olsajiri olsajiri commented Feb 13, 2025

assorted fixes

Copy link

netlify bot commented Feb 13, 2025

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit bde73f2
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/67b1288fc1f5b200081cd72e
😎 Deploy Preview https://deploy-preview-3394--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@olsajiri olsajiri changed the title tetragon: Fix generated_syscalls list tetragon: assorted fixes Feb 13, 2025
@olsajiri olsajiri added the release-note/minor This PR introduces a minor user-visible change label Feb 14, 2025
@olsajiri olsajiri force-pushed the pr/olsajiri/fixes branch 2 times, most recently from e51e318 to b1872eb Compare February 16, 2025 09:41
@olsajiri olsajiri marked this pull request as ready for review February 16, 2025 14:16
@olsajiri olsajiri requested a review from a team as a code owner February 16, 2025 14:16
@olsajiri olsajiri requested review from tpapagian and kkourt February 16, 2025 14:16
Copy link
Member

@tpapagian tpapagian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@olsajiri olsajiri marked this pull request as draft February 18, 2025 11:31
Currently we do not inlcude sys prefix in generated syscall list,
so the list fails validation and the spec like this one fails:

  spec:
    lists:
    - name: "all-syscalls"
      type: "generated_syscalls"
    kprobes:
    - call: "list:all-syscalls"

Adding missing "sys_" prefix.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
The ksyms.KernelSymbols call is expensive, let's do it just once.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Let's use GetInitialSensorTest in all tests now that we have it.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Let's unify the process annotation for tracepoints. Next patch moves
all the same code into separate function, so making the change explicit
for tracepoints.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Move the common code for process and parent retrival code
to separate getProcessParent function.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
@olsajiri olsajiri marked this pull request as ready for review February 18, 2025 15:09
@olsajiri olsajiri merged commit b7f6a8d into main Feb 18, 2025
42 checks passed
@olsajiri olsajiri deleted the pr/olsajiri/fixes branch February 18, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/minor This PR introduces a minor user-visible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants