-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tetragon: assorted fixes #3394
Merged
Merged
tetragon: assorted fixes #3394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
fc8865a
to
6c5c716
Compare
e51e318
to
b1872eb
Compare
tpapagian
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
mtardy
approved these changes
Feb 18, 2025
Currently we do not inlcude sys prefix in generated syscall list, so the list fails validation and the spec like this one fails: spec: lists: - name: "all-syscalls" type: "generated_syscalls" kprobes: - call: "list:all-syscalls" Adding missing "sys_" prefix. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
The ksyms.KernelSymbols call is expensive, let's do it just once. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Let's use GetInitialSensorTest in all tests now that we have it. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Let's unify the process annotation for tracepoints. Next patch moves all the same code into separate function, so making the change explicit for tracepoints. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Move the common code for process and parent retrival code to separate getProcessParent function. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
b1872eb
to
c134c63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assorted fixes