api: build using buf #3368
Merged
api: build using buf #3368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will-isovalent
force-pushed
the
pr/will/buf
branch
7 times, most recently
from
c0761af to
a7eaa87
Compare
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
will-isovalent
force-pushed
the
pr/will/buf
branch
3 times, most recently
from
61ab652 to
3760d67
Compare
will-isovalent
added
the
release-note/misc
will-isovalent
force-pushed
the
pr/will/buf
branch
6 times, most recently
from
dd38012 to
de32010
Compare
Refactor our build pipeline for the protobuf API to use buf[1] to do our code generation. This approach has a few key advantages: 1. Simpler and more maintainable. We no longer need to maintain a complex makefile that gets more complex with every new .proto file. 2. Automatic checking for API breakages including JSON and wire compatibility. 3. Linting and automatic code formatting to improve code consistency and enforce best practices. Note: linting is currently disabled pending a larger incoming PR that will address current issues. [1]: https://buf.build/docs/cli/ Signed-off-by: William Findlay <william.findlay@isovalent.com>
will-isovalent
force-pushed
the
pr/will/buf
branch
from
de32010 to
b398807
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor our build pipeline for the protobuf API to use buf1 to do our code generation.
This approach has a few key advantages:
Simpler and more maintainable. We no longer need to maintain a complex makefile that
gets more complex with every new .proto file.
Automatic checking for API breakages including JSON and wire compatibility.
Linting and automatic code formatting to improve code consistency and enforce best
practices. Note: linting is currently disabled pending a larger incoming PR that will
address current issues.