tetra/debug: Clone GetDebugResponse entries #3343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpapagian
added
the
release-note/misc
tpapagian
added
needs-backport/1.2
When running command "tetra debug dump processcache", we get sometimes the following error: Error: failed to get process dump debug info: rpc error: code = Internal desc = grpc: error while marshaling: marshaling tetragon.GetDebugResponse: size mismatch (see golang/protobuf#1609): calculated=1240, measured=1269 By checking the link provided in the error message, we can see that the most possible cause of the error is accidental sharing and concurrent mutation of a Protobuf message or submessage. To avoid that issue, this patch clones mutable submessages. We managed to reproduce that in a server with heavy load. This patch seems to solve that issue. Signed-off-by: Anastasios Papagiannis <anastasios.papagiannis@isovalent.com>
tpapagian
force-pushed
the
pr/apapag/clone_debug_message
branch
from
5b510fa to
17ca292
Compare
kkourt
approved these changes
Jan 28, 2025
mtardy
approved these changes
Jan 28, 2025
This was referenced Jan 28, 2025
tpapagian
added
backport-pending/1.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running comand "tetra debug dump processcache", we get sometimes the following error:
Error: failed to get process dump debug info: rpc error: code = Internal desc = grpc: error while marshaling: marshaling tetragon.GetDebugResponse: size mismatch (see golang/protobuf#1609): calculated=1240, measured=1269
By checking the link provided in the error message, we can see that the most possible cause of the error is accidental sharing and concurrent mutation of a Protobuf message or submessage.
To avoid that issue, this patch clones mutable submessages.
We managed to reproduce that in a server with heavy load. This patch seems to solve that issue.