tetragon: probe_read usage may cause issues with newer kernels #2925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer kernels should not use probe_read so convert to probe_read_kernel. We have logic to rever to probe_read on older kernels when needed. Signed-off-by: John Fastabend <john.fastabend@gmail.com>
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
willfindlay
approved these changes
Sep 13, 2024
jrfastab
force-pushed
the
pr/jrfastab/probe_read_kernel
branch
from
46a92f2 to
c4b63b3
Compare
jrfastab
added
the
release-note/misc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer kernels should not use probe_read so convert to probe_read_kernel. We have logic to revert to probe_read on older kernels. Further using probe_read instead of correct probe_read_{kernel|user} may fault on some architectures.
Changelog
Convert probe_read to probe_read_kernel.