Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Improve/stabilize lint Helm CI workflow #2847

Merged
merged 1 commit into from
Sep 2, 2024
+7 −1
Merged

CI: Improve/stabilize lint Helm CI workflow #2847

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/lint-helm.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ on:
- '.github/workflows/lint-helm.yaml'
workflow_call:

permissions:
pull-requests: write

env:
MIN_K8S_VERSION: "1.23.0"
# renovate: datasource=python-version
Expand Down Expand Up @@ -51,6 +54,7 @@ jobs:

# Validate Helm chart
- name: Generate Helm chart
id: generate_helm_chart
run: |
make -C install/kubernetes
- name: Validate generated files
Expand All @@ -63,13 +67,15 @@ jobs:
# (Re-)run Kubeconform checks explicitly once again to catch specific errors in that regard (to get the STDOUT/STDERR)
- name: Run Kubeconform with minimum supported K8s version
if: success() || steps.generate_helm_chart.outcome == 'failure'
id: kubeconform_min_k8s_version
uses: mathiasvr/command-output@v2.0.0
with:
shell: bash
run: |
make -C install/kubernetes kubeconform K8S_VERSION=${{ env.MIN_K8S_VERSION }}
- name: Run Kubeconform with latest K8s version
if: success() || steps.generate_helm_chart.outcome == 'failure'
id: kubeconform_latest_k8s_version
uses: mathiasvr/command-output@v2.0.0
with:
Expand All @@ -79,7 +85,7 @@ jobs:
# Post Kubeconform issues as comment on the GH PR, if there are any
- name: Comment Kubeconform Output
if: failure() && (steps.kubeconform_min_k8s_version.outcome != 'success' || steps.kubeconform_latest_k8s_version.outcome != 'success')
if: failure() && (steps.kubeconform_min_k8s_version.outcome == 'failure' || steps.kubeconform_latest_k8s_version.outcome == 'failure')
uses: marocchino/sticky-pull-request-comment@v2
with:
hide_and_recreate: true
Expand Down
Loading