Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1.1] Makefile: exclude api tags from version #2539

Merged
merged 1 commit into from
Jun 12, 2024
Merged

[v1.1] Makefile: exclude api tags from version #2539

merged 1 commit into from
Jun 12, 2024

Conversation

kkourt
Copy link
Contributor

@kkourt kkourt commented Jun 11, 2024

Backport of #2538.

@kkourt
Makefile: exclude api tags from version
aabc3ae 
[ upstream commit 8dd832b ]

cf0a49d introduced a tag for the api
module. This, however, breaks the release process because the tarball
image generation uses the api version and fails. Exclude the api tags
from the version.

Signed-off-by: Kornilios Kourtis <kornilios@isovalent.com>
@kkourt kkourt requested a review from a team as a code owner June 11, 2024 16:44
@kkourt kkourt requested review from tixxdz and removed request for a team June 11, 2024 16:44
@kkourt kkourt added the release-note/misc This PR makes changes that have no direct user impact. label Jun 11, 2024
@kkourt kkourt merged commit 5be6767 into v1.1 Jun 12, 2024
36 of 37 checks passed
@kkourt kkourt deleted the pr/kkourt/makefix-fix-v1.1 branch June 12, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtardy mtardy mtardy approved these changes

@tixxdz tixxdz Awaiting requested review from tixxdz tixxdz is a code owner automatically assigned from cilium/tetragon

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kkourt @mtardy