Backport #2144 and #2167 to v1.0 branch #2292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michi-covalent
added
the
release-note/misc
michi-covalent
force-pushed
the
pr/michi/backport-2167
branch
3 times, most recently
from
b4440cd to
6efaf89
Compare
michi-covalent
changed the title
[ upstream commit 9af6da4 ] Signed-off-by: Guozhen She <guozhen.she@snowflake.com> Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
[ upstream commit 0acc05b ] Instead of defining each informer as a separate field in K8sWatcher, define informers map as well as AddInformers and GetInformer methods (to populate the map and retrieve informers). This also required changing how the watcher is started - K8sWatcher now contains startFunc function, which is extended in AddInformers method and called in NewK8sWatcherWithTetragonClient. This refactoring will make it easier to extend the watcher with additional informers or to clean them up if needed. Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
[ upstream commit efbbaa5 ] They are unused. I also merged NewK8sWatcherWithTetragonClient function into NewK8sWatcher and deleted unused code related to these informers. Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
[ upstream commit da91e33 ] Since Start() is now an exported method of K8sWatcher, it makes sense to separate responsibilities of creating and starting the watcher. Signed-off-by: Anna Kapuscinska <anna@isovalent.com> Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
force-pushed
the
pr/michi/backport-2167
branch
from
6efaf89 to
77299db
Compare
lambdanis
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #2144
Ref: #2167