bpf: read_call_arg, copy_path once #2239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generic tracepoint program does not seem to work on GKE kernel 5.15.133+. This patch, modifies read_call_arg to call copy_path only once. The goal is to reduce the complexity by having the code for copy_path() being inlined only once. The error on the GKE kernel is: > loadInstance: opening collection 'bpf/objs/bpf_generic_tracepoint_v511.o' failed: program generic_tracepoint_process_event: load program: operation not supported: stack depth 256 (3214132 line(s) omitted)" As well as: > from 22 to 1547: safe > 1563: R0=inv0 R6=ctx(id=0,off=0,imm=0) R9=map_value(id=0,off=0,ks=4,vs=24304,imm=0) R10=fp0 fp-176=mmmm???? > ; return generic_process_event(ctx, (struct bpf_map_def *)&tp_heap, > 1563: (b7) r0 = 0 > 1564: R0_w=inv0 R6=ctx(id=0,off=0,imm=0) R9=map_value(id=0,off=0,ks=4,vs=24304,imm=0) R10=fp0 fp-176=mmmm???? > 1564: (95) exit > 1563: R0_w=inv0 R6_w=ctx(id=0,off=0,imm=0) R9_w=inv0 R10=fp0 fp-176=mmmm???? > 1563: (b7) r0 = 0 > 1564: R0_w=inv0 R6_w=ctx(id=0,off=0,imm=0) R9_w=inv0 R10=fp0 fp-176=mmmm???? > 1564: (95) exit > verification time 22016603 usec > stack depth 256 > processed 559046 insns (limit It's not clear why the error happens, and we were not able to reproduce it in upstream kernels but this patch seems to fix the issue. Signed-off-by: Kornilios Kourtis <kornilios@isovalent.com>
kkourt
added
the
release-note/misc
|
veristat output seems promising: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generic tracepoint program does not seem to work on GKE kernel 5.15.133+. This patch, modifies read_call_arg to call copy_path only once. The goal is to reduce the complexity by having the code for copy_path() being inlined only once.
The error on the GKE kernel is:
As well as:
It's not clear why the error happens, and we were not able to reproduce it in upstream kernels but this patch seems to fix the issue.