Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: check policy state #2229

Merged
merged 1 commit into from
Mar 21, 2024
Merged

e2e: check policy state #2229

merged 1 commit into from
Mar 21, 2024

Conversation

kkourt
Copy link
Contributor

@kkourt kkourt commented Mar 15, 2024

When we check whether a policy is there, having it appear in the list is not enough. We need to check that its state is enabled and that there are no errors.

Copy link

netlify bot commented Mar 15, 2024

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 174e063
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/65f47ba982531a00086427c4
😎 Deploy Preview https://deploy-preview-2229--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

When we check whether a policy is there, having it appear in the list is
not enough. We need to check that its state is enabled and that there
are no errors.

Signed-off-by: Kornilios Kourtis <kornilios@isovalent.com>
@kkourt kkourt force-pushed the pr/kkourt/e2e-fixes branch from 174e063 to 21cf154 Compare March 15, 2024 17:04
@kkourt kkourt added release-note/misc This PR makes changes that have no direct user impact. area/testing Related to testing labels Mar 18, 2024
@kkourt kkourt marked this pull request as ready for review March 18, 2024 16:30
@kkourt kkourt requested a review from a team as a code owner March 18, 2024 16:30
@kkourt kkourt requested a review from tpapagian March 18, 2024 16:30
@kkourt kkourt merged commit ef9787d into main Mar 21, 2024
35 of 36 checks passed
@kkourt kkourt deleted the pr/kkourt/e2e-fixes branch March 21, 2024 11:48
@mtardy
Copy link
Member

mtardy commented Mar 25, 2024

nice use of that new state thingie!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Related to testing release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants