Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Privileged execution - use nginx instead of test-pod image #2125

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

janvi01
Copy link
Contributor

@janvi01 janvi01 commented Feb 20, 2024

Fixes: #705
Signed-off-by: janvi01 janvibajo1@gmail.com

Signed-off-by: janvi01 <janvibajo1@gmail.com>
@janvi01 janvi01 requested review from mtardy and a team as code owners February 20, 2024 06:58
Copy link

netlify bot commented Feb 20, 2024

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 5d5fa9a
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/65d44d7af59fa00008cca5d9
😎 Deploy Preview https://deploy-preview-2125--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tixxdz tixxdz added release-note/minor This PR introduces a minor user-visible change release-note/docs This PR updates the documentation. labels Feb 23, 2024
Copy link
Member

@tixxdz tixxdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm much appreciated for your contributions! let's wait for @mtardy review too ;-)

@jrfastab
Copy link
Contributor

docs build had some issue with network connections retry fixed it.

@jrfastab
Copy link
Contributor

Otherwise thanks for the patch lgtm.

@jrfastab jrfastab merged commit e27bd32 into cilium:main Feb 29, 2024
37 of 39 checks passed
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I was too late for the review, this is only nit, not a big deal, maybe the # in the config is something we would like to fix.

Comment on lines +30 to +31
# enable-process-cred: true
# enable-process-ns: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we wanted to remove the # here.

```
## Step 1: Enabling Process Credential and Namespace Monitoring

* Edit the Tetragon configmap:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a nit I would have removed all the * and just described steps as paragraphs.

@lambdanis lambdanis removed the release-note/minor This PR introduces a minor user-visible change label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/docs This PR updates the documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Privileged execution use case: use nginx instead of test-pod image
5 participants