-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Privileged execution - use nginx instead of test-pod image #2125
Conversation
Signed-off-by: janvi01 <janvibajo1@gmail.com>
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm much appreciated for your contributions! let's wait for @mtardy review too ;-)
docs build had some issue with network connections retry fixed it. |
Otherwise thanks for the patch lgtm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I was too late for the review, this is only nit, not a big deal, maybe the #
in the config is something we would like to fix.
# enable-process-cred: true | ||
# enable-process-ns: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we wanted to remove the #
here.
``` | ||
## Step 1: Enabling Process Credential and Namespace Monitoring | ||
|
||
* Edit the Tetragon configmap: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as a nit I would have removed all the *
and just described steps as paragraphs.
Fixes: #705
Signed-off-by: janvi01 janvibajo1@gmail.com