Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tetragon: Remove superfluous MapDir #2106

Merged
merged 7 commits into from
Feb 21, 2024
Merged

tetragon: Remove superfluous MapDir #2106

merged 7 commits into from
Feb 21, 2024

Conversation

olsajiri
Copy link
Contributor

@olsajiri olsajiri commented Feb 15, 2024

Removing MapDir as preparation for loader refactoring,
it's not used, BpfDir is enough.

Fixes: #527

@olsajiri olsajiri added release-note/minor This PR introduces a minor user-visible change and removed release-note/minor This PR introduces a minor user-visible change labels Feb 15, 2024
@olsajiri olsajiri force-pushed the pr/olsajiri/map_dir branch 2 times, most recently from 5526678 to 7a0404f Compare February 17, 2024 14:12
It's called as part of the sensor.Load later on.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Removing mapDir from program.LoadProgram and related callers.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Removing mapDir from program.Load* functions and related callers.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Removing MapDir from LoadProbeArgs and from its related users.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Remove mapDir from sensor object and its related users.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Removing mapDir from StartSensorManager and related callers.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Removing option.Config.MapDir variable, it's no longer used.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
@olsajiri olsajiri force-pushed the pr/olsajiri/map_dir branch from 7a0404f to 9a4e37e Compare February 19, 2024 20:37
@olsajiri olsajiri changed the title Pr/olsajiri/map dir tetragon: Remove superfluous MapDir Feb 19, 2024
@olsajiri olsajiri marked this pull request as ready for review February 19, 2024 22:10
@olsajiri olsajiri requested a review from a team as a code owner February 19, 2024 22:10
@olsajiri olsajiri requested a review from kevsecurity February 19, 2024 22:10
Copy link
Contributor

@kevsecurity kevsecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olsajiri olsajiri merged commit a1006ad into main Feb 21, 2024
36 checks passed
@olsajiri olsajiri deleted the pr/olsajiri/map_dir branch February 21, 2024 08:27
@lambdanis lambdanis added release-note/misc This PR makes changes that have no direct user impact. and removed release-note/minor This PR introduces a minor user-visible change labels Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cleanup: merge Config.BpfDir and Config.MapDir
3 participants