-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tetragon: Remove superfluous MapDir #2106
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5526678
to
7a0404f
Compare
It's called as part of the sensor.Load later on. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Removing mapDir from program.LoadProgram and related callers. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Removing mapDir from program.Load* functions and related callers. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Removing MapDir from LoadProbeArgs and from its related users. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Remove mapDir from sensor object and its related users. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Removing mapDir from StartSensorManager and related callers. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Removing option.Config.MapDir variable, it's no longer used. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
7a0404f
to
9a4e37e
Compare
kevsecurity
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing MapDir as preparation for loader refactoring,
it's not used, BpfDir is enough.
Fixes: #527