-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
killer: assorted fixes #2058
Merged
Merged
killer: assorted fixes #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eb6c14a
to
59dbdbd
Compare
9389dc8
to
ea32849
Compare
Based on the link used, so it's not confusing in error messages. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Due to kernel restrictions we can't use override return for security_* functions. Let's detect this and force fmod_ret for such case unless the 'override return' mode is specifically required. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
To make the following changes easier. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Adding killerHandler object to carry the syscall symbols as a preparation for allowing multiple instances of killer sensors. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Adding suppoer to have multiple instances of killer sensor, the limitation on single killer instance in policy stays. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
The killer_data is currently global to all instances of killer sensor, making it easy for tracepoint/kprobe sensors to communicate the NotifyKiller action. But it causes an issue when one killer instance is removed and removes the pinned map. Solving this by making the killer_data map spcific for policy. This way each killer sensor has its own killer_data map and related tracepoints or kprobes are able to map to proper killer_data map. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
So we can set sys_prctl first argument value from following test. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Loading 2 different killer policies in the test and making sure they catch and kill. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
ea32849
to
d138004
Compare
tpapagian
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
kkourt
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forcing fmod_ret method for secrity_* functions.
Allow multiple killer sensors.