Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: unloadpolicy after load #1916

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Conversation

sadath-12
Copy link
Contributor

This pr will unload the policy that was loaded during the test which ultimately closes the issue #1771

@sadath-12 sadath-12 requested a review from a team as a code owner December 26, 2023 06:38
@sadath-12 sadath-12 requested a review from tixxdz December 26, 2023 06:38
@tixxdz tixxdz added the release-note/misc This PR makes changes that have no direct user impact. label Jan 4, 2024
@tixxdz
Copy link
Member

tixxdz commented Jan 4, 2024

Thanks for the fix, can you please make it in one single patch? also maybe try to lookup for other LoadCRDString() calls missing the UnloadCRDString() and fix them if they are bugs.

Much appreciated @sadath-12

@sadath-12
Copy link
Contributor Author

Updated . Thanks @tixxdz

Unload the policy that was loaded during the test

Signed-off-by: sadath-12 <sadathsadu2002@gmail.com>
Copy link

netlify bot commented Jan 8, 2024

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 31090e6
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/659c141598aa530008736045
😎 Deploy Preview https://deploy-preview-1916--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sadath-12
Copy link
Contributor Author

Thanks for helping identify mistakes and Improve this @willfindlay

Copy link
Member

@tixxdz tixxdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @willfindlay for review

@willfindlay willfindlay merged commit 5072b64 into cilium:main Jan 10, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants