tetragon: Switch to clang 15 #1104
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olsajiri
force-pushed
the
clang_15_switch
branch
2 times, most recently
from
70ec69a to
0695bb5
Compare
olsajiri
force-pushed
the
clang_15_switch
branch
from
0695bb5 to
8dcbb94
Compare
The new clang use some new optimalization that uses &= as part for '>' operator code. This messes up with maximum we setup with &= for verifier ending up with verifier error: 1328: (77) r1 >>= 2 1329: (57) r1 &= 1023 1330: (bf) r1 = r2 1331: (57) r1 &= 8188 1332: (79) r2 = *(u64 *)(r10 -48) 1333: (0f) r2 += r1 1334: (61) r2 = *(u32 *)(r2 +0) ... invalid access to map value, value_size=4096 off=8188 size=4 R2 max value is outside of the array range Moving the exact size check into assembly that seems to prevent the new optimalization. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Using new clang 15 to compile bpf code. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
olsajiri
force-pushed
the
clang_15_switch
branch
from
8dcbb94 to
157905b
Compare
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Saw this, just wanted to mention that it should be good now thanks to #2777 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using new clang 15 to compile bpf code.