From e96696032516e33a9e0743750e0d53199a3ead3c Mon Sep 17 00:00:00 2001 From: Mahe Tardy Date: Mon, 11 Mar 2024 12:38:17 +0100 Subject: [PATCH] Makefile: run tests as root without building as root Using the go binary -exec flag to execute the test binary using an arbitrary sudo command instead of executing the whole toolchain as root. This is a very small security change but why not! Signed-off-by: Mahe Tardy --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index cb27b43546b..b9e256fe80a 100644 --- a/Makefile +++ b/Makefile @@ -218,11 +218,11 @@ clean: cli-clean tarball-clean .PHONY: test test: tester-progs tetragon-bpf - $(SUDO) $(GO) test -p 1 -parallel 1 $(GOFLAGS) -gcflags=$(GO_BUILD_GCFLAGS) -timeout $(GO_TEST_TIMEOUT) -failfast -cover ./pkg/... ./cmd/... ./operator/... ${EXTRA_TESTFLAGS} + $(GO) test -exec "$(SUDO)" -p 1 -parallel 1 $(GOFLAGS) -gcflags=$(GO_BUILD_GCFLAGS) -timeout $(GO_TEST_TIMEOUT) -failfast -cover ./pkg/... ./cmd/... ./operator/... ${EXTRA_TESTFLAGS} .PHONY: bench bench: - $(SUDO) $(GO) test -p 1 -parallel 1 -run ^$$ $(GOFLAGS) -gcflags=$(GO_BUILD_GCFLAGS) -timeout $(GO_TEST_TIMEOUT) -failfast -cover ./pkg/... ./cmd/... ./operator/... -bench=. ${EXTRA_TESTFLAGS} + $(GO) test -exec "$(SUDO)" -p 1 -parallel 1 -run ^$$ $(GOFLAGS) -gcflags=$(GO_BUILD_GCFLAGS) -timeout $(GO_TEST_TIMEOUT) -failfast -cover ./pkg/... ./cmd/... ./operator/... -bench=. ${EXTRA_TESTFLAGS} # Agent image to use for end-to-end tests E2E_AGENT ?= "cilium/tetragon:$(DOCKER_IMAGE_TAG)"