Skip to content

Commit

Permalink
tetragon: Remove id from tracing sensors name
Browse files Browse the repository at this point in the history
It' no longer needed, because all sensors are now placed
in policy directory.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
  • Loading branch information
olsajiri committed Jun 10, 2024
1 parent 3328b48 commit c8433e9
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 14 deletions.
5 changes: 1 addition & 4 deletions pkg/sensors/tracing/enforcer.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import (
"path"
"strings"
"sync"
"sync/atomic"

"github.com/cilium/tetragon/pkg/arch"
"github.com/cilium/tetragon/pkg/bpf"
Expand Down Expand Up @@ -95,8 +94,7 @@ func (kp *enforcerPolicy) PolicyHandler(
}
}
if len(spec.Enforcers) > 0 {
name := fmt.Sprintf("enforcer-sensor-%d", atomic.AddUint64(&sensorCounter, 1))
return kp.createEnforcerSensor(spec.Enforcers, spec.Lists, spec.Options, name, policy.TpName())
return kp.createEnforcerSensor(spec.Enforcers, spec.Lists, spec.Options, policy.TpName())
}

return nil, nil
Expand Down Expand Up @@ -185,7 +183,6 @@ func (kp *enforcerPolicy) createEnforcerSensor(
enforcers []v1alpha1.EnforcerSpec,
lists []v1alpha1.ListSpec,
opts []v1alpha1.OptionSpec,
name string,
policyName string,
) (*sensors.Sensor, error) {

Expand Down
2 changes: 0 additions & 2 deletions pkg/sensors/tracing/generictracepoint.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,6 @@ var (
genericTracepointTable = tracepointTable{}

tracepointLog logrus.FieldLogger

sensorCounter uint64
)

type observerTracepointSensor struct {
Expand Down
5 changes: 1 addition & 4 deletions pkg/sensors/tracing/genericuprobe.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import (
"errors"
"fmt"
"path"
"sync/atomic"

"github.com/cilium/ebpf"
"github.com/cilium/tetragon/pkg/api/ops"
Expand Down Expand Up @@ -490,7 +489,5 @@ func (k *observerUprobeSensor) PolicyHandler(
return nil, fmt.Errorf("uprobe sensor does not implement policy filtering")
}

name := fmt.Sprintf("gup-sensor-%d", atomic.AddUint64(&sensorCounter, 1))
policyName := p.TpName()
return createGenericUprobeSensor(name, spec, policyName)
return createGenericUprobeSensor("generic_uprobe", spec, p.TpName())
}
7 changes: 3 additions & 4 deletions pkg/sensors/tracing/policyhandler.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ package tracing
import (
"errors"
"fmt"
"sync/atomic"

"github.com/cilium/tetragon/pkg/eventhandler"
"github.com/cilium/tetragon/pkg/policyfilter"
Expand All @@ -33,16 +32,16 @@ func (h policyHandler) PolicyHandler(

handler := eventhandler.GetCustomEventhandler(policy)
if len(spec.KProbes) > 0 {
name := fmt.Sprintf("gkp-sensor-%d", atomic.AddUint64(&sensorCounter, 1))
name := "generic_kprobe"
err := preValidateKprobes(name, spec.KProbes, spec.Lists)
if err != nil {
return nil, fmt.Errorf("validation failed: %w", err)
}
return createGenericKprobeSensor(spec, name, policyID, policyName, handler)
}
if len(spec.Tracepoints) > 0 {
name := fmt.Sprintf("gtp-sensor-%d", atomic.AddUint64(&sensorCounter, 1))
return createGenericTracepointSensor(name, spec.Tracepoints, policyID, policyName, spec.Lists, handler)
return createGenericTracepointSensor("generic_tracepoint", spec.Tracepoints, policyID,
policyName, spec.Lists, handler)
}
return nil, nil
}

0 comments on commit c8433e9

Please sign in to comment.