reader/exec: Introduce FlagStrings map with flag string values

This is done so that we can conveniently iterate over all common flags. The DecodeCommonFlags() function also reads from this map. Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
cilium · Feb 26, 2024 · c725b93 · c725b93
1 parent de3fe08
commit c725b93
Showing 1 changed file with 29 additions and 63 deletions.
diff --git a/pkg/reader/exec/exec.go b/pkg/reader/exec/exec.go
@@ -10,71 +10,37 @@ import (
 	"golang.org/x/sys/unix"
 )
 
+// TODO: Harmonize these with the API docs (Flags field in tetragon.Process)
+var FlagStrings = map[uint32]string{
+	api.EventExecve:                "execve",
+	api.EventExecveAt:              "execveat",
+	api.EventProcFS:                "procFS",
+	api.EventTruncFilename:         "truncFilename",
+	api.EventTruncArgs:             "truncArgs",
+	api.EventTaskWalk:              "taskWalk",
+	api.EventMiss:                  "miss",
+	api.EventNeedsAUID:             "auid",
+	api.EventErrorFilename:         "errorFilename",
+	api.EventErrorArgs:             "errorArgs",
+	api.EventNoCWDSupport:          "nocwd",
+	api.EventRootCWD:               "rootcwd",
+	api.EventErrorCWD:              "errorCWD",
+	api.EventClone:                 "clone",
+	api.EventErrorCgroupName:       "errorCgroupName",
+	api.EventErrorCgroupId:         "errorCgroupID",
+	api.EventErrorCgroupKn:         "errorCgroupKn",
+	api.EventErrorCgroupSubsysCgrp: "errorCgroupSubsysCgrp",
+	api.EventErrorCgroupSubsys:     "errorCgroupSubsys",
+	api.EventErrorCgroups:          "errorCgroups",
+	api.EventErrorPathComponents:   "errorPathResolutionCwd",
+}
+
 func DecodeCommonFlags(flags uint32) []string {
 	var s []string
-	if (flags & api.EventExecve) != 0 {
-		s = append(s, "execve")
-	}
-	// nolint We still want to support this even though it's deprecated
-	if (flags & api.EventExecveAt) != 0 {
-		s = append(s, "execveat")
-	}
-	if (flags & api.EventProcFS) != 0 {
-		s = append(s, "procFS")
-	}
-	if (flags & api.EventTruncFilename) != 0 {
-		s = append(s, "truncFilename")
-	}
-	if (flags & api.EventTruncArgs) != 0 {
-		s = append(s, "truncArgs")
-	}
-	if (flags & api.EventTaskWalk) != 0 {
-		s = append(s, "taskWalk")
-	}
-	if (flags & api.EventMiss) != 0 {
-		s = append(s, "miss")
-	}
-	if (flags & api.EventNeedsAUID) != 0 {
-		s = append(s, "auid")
-	}
-	if (flags & api.EventErrorFilename) != 0 {
-		s = append(s, "errorFilename")
-	}
-	if (flags & api.EventErrorArgs) != 0 {
-		s = append(s, "errorArgs")
-	}
-	if (flags & api.EventNoCWDSupport) != 0 {
-		s = append(s, "nocwd")
-	}
-	if (flags & api.EventRootCWD) != 0 {
-		s = append(s, "rootcwd")
-	}
-	if (flags & api.EventErrorCWD) != 0 {
-		s = append(s, "errorCWD")
-	}
-	if (flags & api.EventClone) != 0 {
-		s = append(s, "clone")
-	}
-	if (flags & api.EventErrorCgroupName) != 0 {
-		s = append(s, "errorCgroupName")
-	}
-	if (flags & api.EventErrorCgroupId) != 0 {
-		s = append(s, "errorCgroupID")
-	}
-	if (flags & api.EventErrorCgroupKn) != 0 {
-		s = append(s, "errorCgroupKn")
-	}
-	if (flags & api.EventErrorCgroupSubsysCgrp) != 0 {
-		s = append(s, "errorCgroupSubsysCgrp")
-	}
-	if (flags & api.EventErrorCgroupSubsys) != 0 {
-		s = append(s, "errorCgroupSubsys")
-	}
-	if (flags & api.EventErrorCgroups) != 0 {
-		s = append(s, "errorCgroups")
-	}
-	if (flags & api.EventErrorPathComponents) != 0 {
-		s = append(s, "errorPathResolutionCwd")
+	for f, v := range FlagStrings {
+		if (flags & f) != 0 {
+			s = append(s, v)
+		}
 	}
 	return s
 }