Remove tetragon_errors_total{type="handler_error"} metric

It was duplicating tetragon_handler_errors_total. Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
cilium · Sep 2, 2024 · b3ddf95 · b3ddf95
1 parent d042986
commit b3ddf95
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 6 deletions.
diff --git a/contrib/upgrade-notes/latest.md b/contrib/upgrade-notes/latest.md
@@ -53,3 +53,4 @@ tetragon:
   * `tetragon_ringbuf_perf_event_lost_total` -> `tetragon_observer_ringbuf_events_lost_total`
   * `tetragon_ringbuf_queue_received_total` -> `tetragon_observer_ringbuf_queue_events_received_total`
   * `tetragon_ringbuf_queue_lost_total` -> `tetragon_observer_ringbuf_queue_events_lost_total`
+* `tetragon_errors_total{type="handler_error"}` metric is removed. Use `tetragon_handler_errors_total` instead.
diff --git a/docs/content/en/docs/reference/metrics.md b/docs/content/en/docs/reference/metrics.md
diff --git a/pkg/metrics/errormetrics/errormetrics.go b/pkg/metrics/errormetrics/errormetrics.go
@@ -25,8 +25,6 @@ const (
 	ProcessPidTidMismatch
 	// An event is missing process info.
 	EventMissingProcessInfo
-	// An error occurred in an event handler.
-	HandlerError
 	// An event finalizer on Process failed
 	EventFinalizeProcessInfoFailed
 	// Failed to resolve Process uid to username
@@ -42,7 +40,6 @@ var errorTypeLabelValues = map[ErrorType]string{
 	ProcessCacheMissOnRemove:                "process_cache_miss_on_remove",
 	ProcessPidTidMismatch:                   "process_pid_tid_mismatch",
 	EventMissingProcessInfo:                 "event_missing_process_info",
-	HandlerError:                            "handler_error",
 	EventFinalizeProcessInfoFailed:          "event_finalize_process_info_failed",
 	ProcessMetadataUsernameFailed:           "process_metadata_username_failed",
 	ProcessMetadataUsernameIgnoredNotInHost: "process_metadata_username_ignored_not_in_host_namespaces",

diff --git a/pkg/observer/observer.go b/pkg/observer/observer.go
@@ -124,8 +124,6 @@ func (k *Observer) receiveEvent(data []byte) {
 	op, events, err := HandlePerfData(data)
 	opcodemetrics.OpTotalInc(ops.OpCode(op))
 	if err != nil {
-		// Increment error metrics
-		errormetrics.ErrorTotalInc(errormetrics.HandlerError)
 		errormetrics.HandlerErrorsInc(ops.OpCode(op), err.kind)
 		switch err.kind {
 		case errormetrics.HandlePerfUnknownOp: