Remove tetragon_errors_total{type="event_missing_process_info"} metric

It has been replaced by more intuitive metric tetragon_events_missing_process_info_total Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
cilium · Sep 2, 2024 · 2607120 · 2607120
1 parent 2d6709b
commit 2607120
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 6 deletions.
diff --git a/contrib/upgrade-notes/latest.md b/contrib/upgrade-notes/latest.md
@@ -53,3 +53,5 @@ tetragon:
   * `tetragon_ringbuf_perf_event_lost_total` -> `tetragon_observer_ringbuf_events_lost_total`
   * `tetragon_ringbuf_queue_received_total` -> `tetragon_observer_ringbuf_queue_events_received_total`
   * `tetragon_ringbuf_queue_lost_total` -> `tetragon_observer_ringbuf_queue_events_lost_total`
+* `tetragon_errors_total{type="event_missing_process_info"}` metric is replaced by
+  `tetragon_events_missing_process_info_total`.
diff --git a/docs/content/en/docs/reference/metrics.md b/docs/content/en/docs/reference/metrics.md
diff --git a/pkg/metrics/errormetrics/errormetrics.go b/pkg/metrics/errormetrics/errormetrics.go
@@ -23,8 +23,6 @@ const (
 	ProcessCacheMissOnRemove
 	// Tid and Pid mismatch that could affect BPF and user space caching logic
 	ProcessPidTidMismatch
-	// An event is missing process info.
-	EventMissingProcessInfo
 	// An error occurred in an event handler.
 	HandlerError
 	// An event finalizer on Process failed
@@ -41,7 +39,6 @@ var errorTypeLabelValues = map[ErrorType]string{
 	ProcessCacheEvicted:                     "process_cache_evicted",
 	ProcessCacheMissOnRemove:                "process_cache_miss_on_remove",
 	ProcessPidTidMismatch:                   "process_pid_tid_mismatch",
-	EventMissingProcessInfo:                 "event_missing_process_info",
 	HandlerError:                            "handler_error",
 	EventFinalizeProcessInfoFailed:          "event_finalize_process_info_failed",
 	ProcessMetadataUsernameFailed:           "process_metadata_username_failed",

diff --git a/pkg/metrics/eventmetrics/eventmetrics.go b/pkg/metrics/eventmetrics/eventmetrics.go
@@ -14,7 +14,6 @@ import (
 	"github.com/cilium/tetragon/pkg/logger"
 	"github.com/cilium/tetragon/pkg/metrics"
 	"github.com/cilium/tetragon/pkg/metrics/consts"
-	"github.com/cilium/tetragon/pkg/metrics/errormetrics"
 	"github.com/cilium/tetragon/pkg/metrics/syscallmetrics"
 	"github.com/cilium/tetragon/pkg/option"
 	"github.com/cilium/tetragon/pkg/reader/exec"
@@ -116,7 +115,6 @@ func GetProcessInfo(process *tetragon.Process) (binary, pod, workload, namespace
 			pod = process.Pod.Name
 		}
 	} else {
-		errormetrics.ErrorTotalInc(errormetrics.EventMissingProcessInfo)
 		missingProcessInfo.Inc()
 	}
 	return binary, pod, workload, namespace