Remove tetragon_errors_total{type="event_missing_process_info"} metric

It has been replaced by more intuitive metric tetragon_events_missing_process_info_total Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
cilium · Sep 2, 2024 · 1041ffb · 1041ffb
1 parent 0b51f95
commit 1041ffb
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 6 deletions.
diff --git a/contrib/upgrade-notes/latest.md b/contrib/upgrade-notes/latest.md
@@ -60,3 +60,5 @@ tetragon:
   `tetragon_event_cache_fetch_failures_total{entry_type="<entry_type>"}`.
 * `tetragon_event_cache_accesses_total` metric is renamed to `tetragon_event_cache_inserts_total`.
 * `tetragon_event_cache_retries_total` metric is renamed to `tetragon_event_cache_fetch_retries_total`.
+* `tetragon_errors_total{type="event_missing_process_info"}` metric is replaced by
+  `tetragon_events_missing_process_info_total`.
diff --git a/docs/content/en/docs/reference/metrics.md b/docs/content/en/docs/reference/metrics.md
diff --git a/pkg/metrics/errormetrics/errormetrics.go b/pkg/metrics/errormetrics/errormetrics.go
@@ -17,8 +17,6 @@ type ErrorType int
 const (
 	// Tid and Pid mismatch that could affect BPF and user space caching logic
 	ProcessPidTidMismatch ErrorType = iota
-	// An event is missing process info.
-	EventMissingProcessInfo
 	// An error occurred in an event handler.
 	HandlerError
 	// An event finalizer on Process failed
@@ -32,7 +30,6 @@ const (
 
 var errorTypeLabelValues = map[ErrorType]string{
 	ProcessPidTidMismatch:                   "process_pid_tid_mismatch",
-	EventMissingProcessInfo:                 "event_missing_process_info",
 	HandlerError:                            "handler_error",
 	EventFinalizeProcessInfoFailed:          "event_finalize_process_info_failed",
 	ProcessMetadataUsernameFailed:           "process_metadata_username_failed",

diff --git a/pkg/metrics/eventmetrics/eventmetrics.go b/pkg/metrics/eventmetrics/eventmetrics.go
@@ -14,7 +14,6 @@ import (
 	"github.com/cilium/tetragon/pkg/logger"
 	"github.com/cilium/tetragon/pkg/metrics"
 	"github.com/cilium/tetragon/pkg/metrics/consts"
-	"github.com/cilium/tetragon/pkg/metrics/errormetrics"
 	"github.com/cilium/tetragon/pkg/metrics/syscallmetrics"
 	"github.com/cilium/tetragon/pkg/option"
 	"github.com/cilium/tetragon/pkg/reader/exec"
@@ -119,7 +118,6 @@ func GetProcessInfo(process *tetragon.Process) (binary, pod, workload, namespace
 			pod = process.Pod.Name
 		}
 	} else {
-		errormetrics.ErrorTotalInc(errormetrics.EventMissingProcessInfo)
 		missingProcessInfo.Inc()
 	}
 	return binary, pod, workload, namespace