replaced 3 deprecated generic calls to Create() #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chris, this contains only one file, CarouselLayout.cs. The change is to update 3 generic calls to Create() because they are being deprecated. In the project that I am using your carousel, the runtime version is v4.030319 for all of the Xamarin.Forms*, I got this warning "BindableProperty.Create<... is obsolete: Generic version of Create() are no longer supported and deprecated. They will be removed soon.".
I hope this is makes sense to add to your project.
The next pull request I am planning to complete is the vertical scroll option. Again, I will keep it as simple as possible.
thx,
Pat Bradley