Migrate to pydantic 2.0+ #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kaminow could I grab a review here? This should allow us to migrate nicely and unblock downstream, but please double check everything still works as expected for configs. |
kaminow
approved these changes
Oct 10, 2024
mtenn/config.py
Outdated
|
|
||
| # Adjust any length 1 list to be the right length | ||
| for p, list_len in list_lens.items(): | ||
| if list_len == 1: | ||
| values[p] = values[p] * num_layers | ||
|
|
||
| return values | ||
| return self.__dict__.update(values) |
There was a problem hiding this comment.
I don't think update actually returns anything
Suggested change
| return self.__dict__.update(values) | |
| self.__dict__.update(values) | |
| return self.__dict__ |
There was a problem hiding this comment.
Now that you mention it we should return self
There was a problem hiding this comment.
this is due to how the after mode validator works in pydantic 2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72
Status