Added Ki Readout #36
Merged
Added Ki Readout #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reset author too.
kaminow
requested changes
Jan 17, 2024
…e for readout later Co-authored-by: kaminow <51923685+kaminow@users.noreply.github.com>
kaminow
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
looks great, thanks! if you haven't already, I would recommend running a test ML training run (with asapdiscovery-ml) with the new KiReadout class, just to make sure everything works as expected in our pipeline. once you've made sure that's all working correctly, go ahead and merge this in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added Ki Readout in readout.py and config.py
Todos
Need code review.
Status