Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Unify conversion_utils #34

Merged
merged 12 commits into from
Jan 8, 2024
Merged

[WIP] Unify conversion_utils #34

merged 12 commits into from
Jan 8, 2024

Conversation

kaminow
Copy link
Collaborator

@kaminow kaminow commented Nov 9, 2023

Make it so that constructing models from conversion_utils has the same function signatures regardless of which model you're using. Closes #33.

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2023

Codecov Report

Merging #34 (061037d) into main (011c066) will increase coverage by 10.71%.
Report is 3 commits behind head on main.
The diff coverage is 84.36%.

Additional details and impacted files

@kaminow kaminow marked this pull request as ready for review January 5, 2024 19:14
@kaminow kaminow requested a review from hmacdope January 5, 2024 19:14
Copy link
Contributor

@hmacdope hmacdope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good! feel free to merge, then cut release (you can even update conda feedstock now)!

@kaminow kaminow merged commit 3cae786 into main Jan 8, 2024
4 checks passed
@kaminow kaminow deleted the unify-conversion-utils branch January 8, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify conversion_utils model constructors
3 participants