-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assertions never seem to fail #51
Comments
At first glance everything looks good. My only guess is that the resource helpers are not returning what they should. Can you tell us which version of Chef and minitest-chef-handler you're using? That would help to narrow the possibilities. |
The version of minitest would also help. |
Chef 10.16.2 When I checked the system gems on the VM I see the following [vagrant@prism-berkshelf cookbooks]$ gem list | grep mini I hope this helps! -John -John Dyer e. johntdyer@gmail.comSent from mobile The version of minitest would also help. — |
thanks @johntdyer. For three or four versions, the file resources in Chef were completely broken due to their effort to support windows. I know this is not what you expect but I'd recommend you to upgrade to the latest version in the series 10.18 if you want to use the resource matchers, everything should work fine then. If you can't/don't want to upgrade your version of Chef, you can go with straight ruby and do something like this: it { File.exist?(file_path).should be_true } That should work regardless your version of Chef. Please, let me know if any this works for you. Thanks again for taking your time reporting this. |
Hey, So I am not sure if this is in fact the issue... So I set up my test so pretty much ALL of them should fail, especially the file one require 'minitest/spec'
require File.expand_path('../support/helpers', __FILE__)
describe_recipe "prism::default" do
include Helpers::Prism
describe "test" do
## THIS SHOULD FAIL
it { File.exist?("/file/that/doesnt/exist").should be_true }
end
describe "voxeo-smanager" do
it "should have voxeo-smanger running" do
service("voxeo-smanager").must_be_running
end
it "should have voxeo-smanger running" do
service("voxeo-smanager").must_be_enabled
end
it "should respond on control port when running" do
## THIS SHOULD FAIL
assert shell_out("curl -sI http://localhost:10086").exitstatus.should eql 1
end
end
describe "voxeo-as" do
it "should respond via http when running" do
## THIS SHOULD FAIL
assert shell_out("curl -sI http://localhost:8080").exitstatus.should eql 1
end
it "should have voxeo-as running" do
service("voxeo-as").must_be_enabled
end
it "should have voxeo-ms running" do
service("voxeo-ms").must_be_enabled
end
end
describe "voxeo-ms" do
it "should have voxeo-as running" do
service("voxeo-as").must_not_be_running
end
it "should have voxeo-ms running" do
service("voxeo-ms").must_be_running
end
it "should respond on control port when running" do
## THIS SHOULD FAIL
assert shell_out("curl -sI http://localhost:10099").exitstatus.should eql 1
end
end
describe "service_report" do
it "should not have any failures" do
service_report = shell_out "service_report"
service_report.stdout.must_not_match(/Failures/) #this is a regex match
end
end
end If you notice its saying I am making 0 assertions 2013-03-24T16:00:52+00:00] INFO: Running report handlers
Run options: -v --seed 3199
# Running tests:
recipe::prism::default::service_report#test_0001_should_not_have_any_failures =
0.00 s =
true
recipe::prism::default::test#test_0001_anonymous =
0.00 s =
true
recipe::prism::default::voxeo-as#test_0001_should_respond_via_http_when_running =
0.00 s =
true
recipe::prism::default::voxeo-as#test_0002_should_have_voxeo_as_running =
0.00 s =
true
recipe::prism::default::voxeo-as#test_0003_should_have_voxeo_ms_running =
0.00 s =
true
recipe::prism::default::voxeo-ms#test_0001_should_have_voxeo_as_running =
0.00 s =
true
recipe::prism::default::voxeo-ms#test_0002_should_have_voxeo_ms_running =
0.00 s =
true
recipe::prism::default::voxeo-ms#test_0003_should_respond_on_control_port_when_running =
0.00 s =
true
recipe::prism::default::voxeo-smanager#test_0003_should_respond_on_control_port_when_running =
0.00 s =
true
recipe::prism::default::voxeo-smanager#test_0002_should_have_voxeo_smanger_running =
0.00 s =
true
recipe::prism::default::voxeo-smanager#test_0001_should_have_voxeo_smanger_running =
0.00 s =
true
Finished tests in 0.051378s, 214.0994 tests/s, 0.0000 assertions/s.
11 tests, 0 assertions, 0 failures, 0 errors, 0 skips
[2013-03-24T16:00:52+00:00] INFO: Report handlers complete
[2013-03-24T16:00:52+00:00] DEBUG: Exiting
Any ideas? |
@calavera Any ideas? |
Anyone else have any ideas here ? |
Hey Guys,
So I just started playing with minitest, and so far the idea sounds great but I am having a little trouble...
I was able to get the tests to run, as evident in the logs below, however it doesn't seem like any of my assertions ever fail
Here is my default_test.rb
my helpers.rb
You can see that all my tests always pass
However some of these tests should absolutely be failing.... . Any idea what the heck I am doing wrong?
The text was updated successfully, but these errors were encountered: