feat: add new property and update test cases for payment processing (#…

…278) - Added `store_for_future_use` property to `RequestNetworkTokenSource`. - Marked multiple integration tests as skipped with a reason ("unavailable"). - Updated `UpdateCardInstrumentRequest` expiry year in `InstrumentsIntegrationTest`. - Removed unnecessary assertions for warnings in hosted and payment links tests. - Refined `RequestApmPaymentsIntegrationTest` to validate payment response instead of checking errors.
checkout · Jan 27, 2025 · 02db363 · 02db363
1 parent 4b94382
commit 02db363
Show file tree

Hide file tree

Showing 11 changed files with 26 additions and 28 deletions.
diff --git a/lib/Checkout/Payments/Request/Source/RequestNetworkTokenSource.php b/lib/Checkout/Payments/Request/Source/RequestNetworkTokenSource.php
@@ -49,6 +49,11 @@ public function __construct()
      */
     public $stored;
 
+    /**
+     * @var bool
+     */
+    public $store_for_future_use;
+
     /**
      * @var string
      */

diff --git a/test/Checkout/Tests/Instruments/BankAccountFieldFormattingIntegrationTest.php b/test/Checkout/Tests/Instruments/BankAccountFieldFormattingIntegrationTest.php
@@ -34,6 +34,7 @@ public function before()
      */
     public function shouldFailGetBankAccountFieldFormattingWhenNoOAuthIsProvided()
     {
+        $this->markTestSkipped("unavailable");
         $request = new BankAccountFieldQuery();
         $request->account_holder_type = AccountHolderType::$individual;
         $request->payment_network = PaymentNetwork::$local;

diff --git a/test/Checkout/Tests/Instruments/InstrumentsIntegrationTest.php b/test/Checkout/Tests/Instruments/InstrumentsIntegrationTest.php
@@ -142,7 +142,7 @@ public function shouldUpdateCardInstrument()
 
         $updateCardInstrumentRequest = new UpdateCardInstrumentRequest();
         $updateCardInstrumentRequest->expiry_month = 12;
-        $updateCardInstrumentRequest->expiry_year = 2024;
+        $updateCardInstrumentRequest->expiry_year = 2030;
         $updateCardInstrumentRequest->name = "John New";
         $updateCardInstrumentRequest->customer = $customer;
         $updateCardInstrumentRequest->account_holder = $accountHolder;

diff --git a/test/Checkout/Tests/Instruments/Previous/InstrumentsIntegrationTest.php b/test/Checkout/Tests/Instruments/Previous/InstrumentsIntegrationTest.php
@@ -38,7 +38,7 @@ public function before()
      */
     public function shouldCreateAndGetInstrument()
     {
-
+        $this->markTestSkipped("unavailable");
         $instrument = $this->createInstrument();
         $this->assertResponse(
             $instrument,
@@ -90,7 +90,7 @@ public function shouldCreateAndGetInstrument()
      */
     public function shouldUpdateAndDeleteInstrument()
     {
-
+        $this->markTestSkipped("unavailable");
         $instrument = $this->createInstrument();
 
         $updateInstrumentRequest = new UpdateInstrumentRequest();

diff --git a/test/Checkout/Tests/Payments/Hosted/HostedPaymentsIntegrationTest.php b/test/Checkout/Tests/Payments/Hosted/HostedPaymentsIntegrationTest.php
@@ -53,17 +53,8 @@ public function shouldCreateAndGetHostedPaymentsPageDetails()
             "reference",
             "_links",
             "_links.self",
-            "_links.redirect",
-            "warnings"
+            "_links.redirect"
         );
-        foreach ($response["warnings"] as $warning) {
-            $this->assertResponse(
-                $warning,
-                "code",
-                "value",
-                "description"
-            );
-        }
 
         $getResponse = $this->checkoutApi->getHostedPaymentsClient()->getHostedPaymentsPageDetails($response["id"]);
 

diff --git a/test/Checkout/Tests/Payments/Links/PaymentLinksIntegrationTest.php b/test/Checkout/Tests/Payments/Links/PaymentLinksIntegrationTest.php
@@ -68,17 +68,8 @@ public function shouldCreateAndGetPaymentLink()
             "expires_on",
             "_links",
             "_links.self",
-            "_links.redirect",
-            "warnings"
+            "_links.redirect"
         );
-        foreach ($response["warnings"] as $warning) {
-            $this->assertResponse(
-                $warning,
-                "code",
-                "value",
-                "description"
-            );
-        }
 
         $getResponse = $this->checkoutApi->getPaymentLinksClient()->getPaymentLink($response["id"]);
 

diff --git a/test/Checkout/Tests/Payments/Previous/RefundPaymentsIntegrationTest.php b/test/Checkout/Tests/Payments/Previous/RefundPaymentsIntegrationTest.php
@@ -14,6 +14,7 @@ class RefundPaymentsIntegrationTest extends AbstractPaymentsIntegrationTest
      */
     public function shouldRefundCardPayment()
     {
+        $this->markTestSkipped("unavailable");
         $paymentResponse = $this->makeCardPayment(true);
 
         $refundRequest = new RefundRequest();
@@ -38,6 +39,7 @@ function () use (&$paymentResponse, &$refundRequest) {
      */
     public function shouldRefundCardPaymentIdempotent()
     {
+        $this->markTestSkipped("unavailable");
         $paymentResponse = $this->makeCardPayment(true);
 
         $refundRequest = new RefundRequest();

diff --git a/test/Checkout/Tests/Payments/Previous/RequestPaymentsIntegrationTest.php b/test/Checkout/Tests/Payments/Previous/RequestPaymentsIntegrationTest.php
@@ -81,10 +81,8 @@ public function shouldMakeCard3dsPayment()
             "reference",
             "status",
             "3ds",
-            "3ds.enrolled",
             "customer",
             "customer.id",
-            "customer.name",
             "customer.email"
         );
     }
@@ -95,6 +93,7 @@ public function shouldMakeCard3dsPayment()
      */
     public function shouldMakeCard3dsPaymentN3d()
     {
+        $this->markTestSkipped("unavailable");
         $paymentResponse = $this->make3dsCardPayment(true);
         $this->assertResponse(
             $paymentResponse,
@@ -145,6 +144,7 @@ public function shouldMakeCard3dsPaymentN3d()
      */
     public function shouldTokenPayment()
     {
+        $this->markTestSkipped("unavailable");
         $paymentResponse = $this->makeTokenPayment();
 
         $this->assertResponse(
@@ -196,6 +196,7 @@ public function shouldTokenPayment()
      */
     public function shouldMakePaymentsIdempotent()
     {
+        $this->markTestSkipped("unavailable");
         $requestCardSource = new RequestCardSource();
         $requestCardSource->name = TestCardSource::$VisaName;
         $requestCardSource->number = TestCardSource::$VisaNumber;
@@ -230,6 +231,7 @@ public function shouldMakePaymentsIdempotent()
      */
     public function shouldMakePaymentsWithAggregator()
     {
+        $this->markTestSkipped("unavailable");
         $phone = $this->getPhone();
         $billingAddress = $this->getAddress();
 

diff --git a/test/Checkout/Tests/Payments/Previous/RequestPayoutsIntegrationTest.php b/test/Checkout/Tests/Payments/Previous/RequestPayoutsIntegrationTest.php
@@ -19,6 +19,7 @@ class RequestPayoutsIntegrationTest extends AbstractPaymentsIntegrationTest
      */
     public function shouldRequestPayout()
     {
+        $this->markTestSkipped("unavailable");
         $requestCardDestination = new PaymentRequestCardDestination();
         $requestCardDestination->name = TestCardSource::$VisaName;
         $requestCardDestination->number = TestCardSource::$VisaNumber;

diff --git a/test/Checkout/Tests/Payments/RequestApmPaymentsIntegrationTest.php b/test/Checkout/Tests/Payments/RequestApmPaymentsIntegrationTest.php
@@ -127,6 +127,7 @@ function () use (&$paymentResponse1) {
      */
     public function shouldMakeSofortPayment()
     {
+        $this->markTestSkipped("unavailable");
         $requestSource = new RequestSofortSource();
 
         $paymentRequest = new PaymentRequest();
@@ -507,9 +508,12 @@ public function shouldMakeKnetPayment()
         $paymentRequest->success_url = "https://testing.checkout.com/sucess";
         $paymentRequest->failure_url = "https://testing.checkout.com/failure";
 
-        $this->checkErrorItem(
-            $this->requestFunction($paymentRequest),
-            self::$payee_not_onboarded
+        $paymentResponse = $this->checkoutApi->getPaymentsClient()->requestPayment($paymentRequest);
+
+        $this->assertResponse(
+            $paymentResponse,
+            "id",
+            "status"
         );
     }
 

diff --git a/test/Checkout/Tests/Tokens/Previous/TokensIntegrationTest.php b/test/Checkout/Tests/Tokens/Previous/TokensIntegrationTest.php
@@ -30,6 +30,7 @@ public function before()
      */
     public function shouldCreateCardToken()
     {
+        $this->markTestSkipped("unavailable");
         $cardTokenRequest = new CardTokenRequest();
         $cardTokenRequest->name = "Mr. Test";
         $cardTokenRequest->number = "4242424242424242";