Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace subject with [...] for outgoing mail #481

Merged
merged 1 commit into from
Feb 16, 2025
Merged

Conversation

link2xt
Copy link
Contributor

@link2xt link2xt commented Jan 29, 2025

authclean cleanup server is used by
reinjecting smtpd running on localhost:10025 by default. It runs after filtermail
and currently removes Received header
to avoid leaking IP address.
Can as well be used to replace Subject lines
with Subject: [...].
If there are multiple Subject lines,
all of them should be replaced.

This allows us to avoid dealing with
localized subjects, including SecureJoin
messages vc-request and vg-request
which can have Subject lines like
Subject: =?utf-8?q?Nachricht_von_nrn178fi4=40nine=2Etestrun=2Eorg?=

@link2xt link2xt force-pushed the link2xt/replace-subject branch from 05392d4 to 7fe2f3a Compare January 29, 2025 00:13
@link2xt link2xt marked this pull request as draft January 29, 2025 00:13
@link2xt link2xt force-pushed the link2xt/replace-subject branch from 7fe2f3a to 552fe0f Compare January 29, 2025 00:27
@link2xt link2xt marked this pull request as ready for review February 16, 2025 12:19
@link2xt link2xt requested review from missytake, hpk42 and dkg February 16, 2025 20:56
Copy link
Contributor

@missytake missytake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great :) would be nice to have a test which ensures that the subject is overridden...

@link2xt link2xt force-pushed the link2xt/replace-subject branch from 552fe0f to 05cf83e Compare February 16, 2025 21:35
`authclean` cleanup server is used by
reinjecting smtpd running on localhost:10025 by default.
It runs after filtermail
and currently removes `Received` header
to avoid leaking IP address.
Can as well be used to replace `Subject` lines
with `Subject: [...]`.
If there are multiple `Subject` lines,
all of them should be replaced.

This allows us to avoid dealing with
localized subjects, including SecureJoin
messages `vc-request` and `vg-request`
which can have Subject lines like
Subject: =?utf-8?q?Nachricht_von_nrn178fi4=40nine=2Etestrun=2Eorg?=
@link2xt link2xt force-pushed the link2xt/replace-subject branch from 05cf83e to 268eda8 Compare February 16, 2025 21:58
@link2xt
Copy link
Contributor Author

link2xt commented Feb 16, 2025

Added a test

@link2xt link2xt merged commit 2daac76 into main Feb 16, 2025
6 checks passed
@link2xt link2xt deleted the link2xt/replace-subject branch February 16, 2025 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants