Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace deprecated crypt package with crypt-r #475

Merged
merged 1 commit into from
Jan 26, 2025
Merged

Conversation

adbenitez
Copy link
Contributor

@adbenitez adbenitez commented Jan 25, 2025

CI is currently failing because crypt package was deprecated and finally removed in python 3.13, the package was moved out of the standard lib and is available via pypi: https://pypi.org/project/crypt-r/

close #318

@link2xt
Copy link
Contributor

link2xt commented Jan 25, 2025

Needs a rebase? Lint warning is fixed on main already.

I reopened #318

Copy link
Contributor

@link2xt link2xt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a changelog entry as well, I think it is worth mentioning there.

@link2xt
Copy link
Contributor

link2xt commented Jan 26, 2025

I fixed CI on main, going to merge this and will check that CI still works.

@link2xt link2xt merged commit 20f76c8 into main Jan 26, 2025
4 of 6 checks passed
@link2xt link2xt deleted the adb/use-crypt-r branch January 26, 2025 19:48
@link2xt
Copy link
Contributor

link2xt commented Jan 26, 2025

It failed CI >_<

ERROR: Could not build wheels for crypt-r, which is required to install pyproject.toml-based projects

@link2xt link2xt mentioned this pull request Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python: migrate away from crypt library
3 participants