DNS: fix _mta-sts TXT record on initial setup #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6d4af3c.
hpk42
reviewed
Dec 17, 2024
cmdeploy/src/cmdeploy/remote/rdns.py
Outdated
| @@ -34,7 +35,10 @@ def perform_initial_checks(mail_domain): | |||
|
|
|||
| # parse out sts-id if exists, example: "v=STSv1; id=2090123" | |||
| parts = query_dns("TXT", f"_mta-sts.{mail_domain}").split("id=") | |||
| res["sts_id"] = parts[1].rstrip('"') if len(parts) == 2 else "" | |||
| if len(parts) == 2 and len(parts[1]) > 1: | |||
There was a problem hiding this comment.
there is a much more elegant fix now <.<
missytake
force-pushed
the
fix-mta-sts-460
branch
from
282562c to
16fa253
Compare
|
changelog missing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #460