Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print unparseable input as a string #107

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Conversation

link2xt
Copy link
Contributor

@link2xt link2xt commented Aug 29, 2024

Otherwise users get error messages
where unparseable server response
is printed as an array of bytes
such as
[50, 50, 48, 32, 109, 97, 105, 108, 46, 101, 120, 97, 109, 112, 108, 101, 46, 111, 114, 103, 32, 69, 83, 77, 84, 80, 32, 80, 111, 115, 116, 99, 111, 119]

Otherwise users get error messages
where unparseable server response
is printed as an array of bytes
such as
[50, 50, 48, 32, 109, 97, 105, 108, 46, 101, 120, 97, 109, 112, 108, 101, 46, 111, 114, 103, 32, 69, 83, 77, 84, 80, 32, 80, 111, 115, 116, 99, 111, 119]
@link2xt link2xt requested a review from dignifiedquire August 29, 2024 17:04
@iequidoo
Copy link

I think we need a new release after merging this to use new append() powers in chatmail/core#5901

@link2xt link2xt merged commit 84b7b00 into main Aug 30, 2024
22 checks passed
@link2xt link2xt deleted the link2xt/unparsed-result-as-string branch August 30, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants