Migrate to sea-orm instead of Diesel
#1852
Conversation
auguwu
added
documentation
There was a problem hiding this comment.
This is fantastic - thank you so much for migrating everything over! I'm a little confused on why cargo deny is failing here, but I don't believe it's our fault.
I believe this should be set to merge; would it be possible to rebase everything on top of recent commits?
I forgot to set the PR to a draft, everything is not 100% finished yet. But, it shouldn't hurt to rebase everything now. CI will need a bit of updating (especially our release pipeline, which is going to be a lot more complex and require a lot of compute (I am tempted to get GitHub Teams for this organization so we can have the large runners as I do not have access to aarch64 Linux machines)) |
…ted-types is 100% finished
… updates on configuration without a file
This is under a Cargo crate features, distributions can disable it with `--no-default-features`. It doesn't require the actual libsystemd to be avaliable.
|
I think it's time to merge changes since we're back to where we started. |
yet another PR that Noel makes that refractors a whole lot but this is the last time I swear!This gigantic PR migrates away from Diesel and experiments with sea-orm. There are numerous reasons why I decided to migrate to sea-orm:
Uses
sqlxas the database library, solibsqlite3andlibpqare not required. PRs like fix(deps): update rust crate libsqlite3-sys to 0.31.0 #1849 and fix(deps): update rust crate pq-sys to 0.7.0 #1847 don't happen & eliminate requirements for thebundled_{sqlite,pq}feature flags in thechartedbinary.Diesel requires a LOT of derive macros and magic to work properly and it can easily break when managing multiple databases (ref.
charted_database::connection!invocations in src tree)While sea-orm does require some code to work for newtypes and other fun stuff, it isn't as from diesel and trying to juggle multiple databases is very easy and doesn't even require the hard work (like
charted_database::connection!and such)This PR also cleans up the
crates/library and prepares thecharted-typesandcharted-corecrates to be public to crates.io for the REST client (charted-client) to be readily available at launch.