-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transmit kubernetes tokens using juju secrets #2
Conversation
727de2a
to
9430331
Compare
4e60b64
to
ea36063
Compare
ea36063
to
1a431be
Compare
f5f5971
to
16bbb0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I have a couple of comments and suggestions, feel free to disregard if they’re not relevant
ca_certificate str: The CA certificate in PEM format. | ||
""" | ||
content = {"ca-certificate": ca_certificate} | ||
secret = self.refresh_secret_content( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for setting it as a secret
tokens.client_token = "" | ||
tokens.kubelet_token = "" | ||
tokens.proxy_token = "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we set this to ""
, it will still be parsed into the dict and json representation. If that's okay, we can leave it as is. However, if we want to omit these values, we should set them to None
instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll document here why they must be filled with something
b42267f
to
91ccb3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for adding a revoking mechanism.
Overview
Details