feat: Add optional feature_type member to the SubscriptionEntitlemet model #53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
A typical use case for me is to check the
value
when fetchingSubscriptionEntitlement
. One example API call:The value heavily depends on the
feature_type
. E.g.value
is a string representation of an integer, let's say"5"
, whenfeature_type
isQUANTITY
. In this scenario, I might want toparseInt(value, 10)
in order to perform arithmetics on the value and so on. That said, I believe this can beunlimited
as well so one should be careful here I would presume.That said, the value might also be
available
, e.g. if thefeature_type
is"SWITCH"
. Then the formerly mentioned comparison of integers make no sense.In summary, my point is the feature_type is essential when checking if a user has access. I'm not sure how this can be overlooked in this API and it makes me actually question if my approach is valid. Let me know if there are better ways to check access using features/entitlements.
Description of changeset
Adds
feature_type
to theSubscriptionEntitlement
model as this is available in the API response. If this is always expected to be present, I would prefer to change this to non-optional.