-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] Update "Functions that Checking Units or Assigning Units" and Fix some typo #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request corrects unit scale factors in Class diagram showing unit constant updatesclassDiagram
class Unit {
+create(dim, name, dispname, scale, factor)
}
class PressureUnits {
+atmosphere: Unit
+bar: Unit
+torr: Unit
+psi: Unit
}
class EnergyUnits {
+electron_volt: Unit
}
note for PressureUnits "Scale factors updated to use pascal.scale"
note for EnergyUnits "Scale factor updated to use joule.scale - 19"
Unit <|-- PressureUnits
Unit <|-- EnergyUnits
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Routhleck - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider doing a final proofreading pass on the documentation text to fix minor typos and improve readability.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the
brainunit/_unit_constants.py
file to correct the scale factors for various units and updates to thedocs/index.rst
file to include new documentation links. The most important changes are as follows:Corrections to unit scale factors:
brainunit/_unit_constants.py
: Corrected the scale factors for pressure units (atmosphere
,bar
,torr
,psi
) to usepascal.scale
instead ofmeter.scale
.brainunit/_unit_constants.py
: Corrected the scale factor for the energy unitelectronvolt
to usejoule.scale - 19
instead of-19
.Documentation updates:
docs/index.rst
: Added new links to the documentation forlinalg_functions.ipynb
,fft_functions.ipynb
, andlax_functions.ipynb
.Summary by Sourcery
Clarify the usage of functions for checking and assigning units, and add examples for using decorators.
Enhancements:
Documentation:
check_dims
,check_units
, andassign_units
decorators with examples.