Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use aggregator::setup in test calculate_num_required_nofn_sigs #471

Closed
ceyhunsen opened this issue Jan 27, 2025 · 1 comment
Closed

Use aggregator::setup in test calculate_num_required_nofn_sigs #471

ceyhunsen opened this issue Jan 27, 2025 · 1 comment
Assignees
@ceyhunsen
Labels
code quality Improves code quality while not affecting any other
Milestone
Automatic Disprov...

Comments

@ceyhunsen
Copy link
Member

Proposal Description

calculate_num_required_nofn_sigs test manually setups database because there is an unidentified bug in create_actors!. Ideally, this should be done with aggregator::setup call.
@ceyhunsen ceyhunsen added the code quality Improves code quality while not affecting any other label Jan 27, 2025
@ceyhunsen ceyhunsen self-assigned this Jan 27, 2025
@ceyhunsen ceyhunsen mentioned this issue Feb 5, 2025
Merged
@mmtftr
Copy link

mmtftr commented Mar 11, 2025

Closed since this test was removed due to a refactor (moving to sigtypes and tagged sighashes)

@mmtftr mmtftr closed this as completed Mar 11, 2025
@ceyhunsen ceyhunsen mentioned this issue Mar 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ceyhunsen ceyhunsen

Labels
code quality Improves code quality while not affecting any other
Projects
None yet
Milestone
Automatic Disprove Logic
Development

No branches or pull requests
3 participants
@mmtftr @ekrembal @ceyhunsen