Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of cli wallet #1888

Merged
merged 2 commits into from
Feb 14, 2025
Merged

Get rid of cli wallet #1888

merged 2 commits into from
Feb 14, 2025

Conversation

ercecan
Copy link
Member

@ercecan ercecan commented Feb 14, 2025

Description

Get rid of unused sovereign cli wallet
Needed for easier development of #1787

@ercecan ercecan requested a review from eyusufatik as a code owner February 14, 2025 13:20
@auto-assign auto-assign bot requested a review from jfldde February 14, 2025 13:20
@eyusufatik eyusufatik merged commit 62c57d4 into nightly Feb 14, 2025
12 checks passed
@eyusufatik eyusufatik deleted the erce/remove-cli-wallet branch February 14, 2025 14:05
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.7%. Comparing base (490bc8f) to head (50b2ea3).
Report is 1 commits behind head on nightly.

Additional details and impacted files
Files with missing lines Coverage Δ
...reign-sdk/module-system/sov-modules-api/src/lib.rs 100.0% <ø> (ø)
...sdk/module-system/sov-modules-macros/src/common.rs 84.0% <ø> (+13.4%) ⬆️
...gn-sdk/module-system/sov-modules-macros/src/lib.rs 75.8% <ø> (+9.6%) ⬆️

... and 7 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants