Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SpecId::latest() for tests() #1869

Open
kpp opened this issue Feb 11, 2025 · 1 comment
Open

SpecId::latest() for tests() #1869

kpp opened this issue Feb 11, 2025 · 1 comment
Labels
M - good first issue Good for newcomers P-low Low priority

Comments

@kpp
Copy link
Contributor

kpp commented Feb 11, 2025

How about we implement:

impl SpecId {
pub fn latest() -> Self {
Self::Fork2
}
}

And use this SpecId::latest() everywhere?

#1862 (comment)
@kpp kpp added M - good first issue Good for newcomers P-low Low priority labels Feb 11, 2025
@kpp kpp mentioned this issue Feb 11, 2025
Merged
@eyusufatik
Copy link
Member

good call

@eyusufatik eyusufatik linked a pull request Feb 20, 2025 that will close this issue
Add system contract upgrade with Safe multisig test #1938
Merged
@eyusufatik eyusufatik removed a link to a pull request Feb 20, 2025
Add system contract upgrade with Safe multisig test #1938
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
M - good first issue Good for newcomers P-low Low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kpp @eyusufatik