Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax requirements for stable SHA on the signature part of the package #45

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sfc-gh-ptabor
Copy link
Collaborator

Currently when signature part of package changes, it triggers immediate failure of the build process
(especially when the lock-file is used).

Here we prefer to use the predefined hash to fetch the artifact (for perfomance reasons) and to have the warning printed if the SHAs does not match -> but still allow the build process to proceeed.

@sfc-gh-ptabor
Copy link
Collaborator Author

sfc-gh-ptabor commented Dec 15, 2023

@thesayyn Please take a look in context of your comment: #42 (comment)

to avoid hard fails, in case the signature change, we only cache control and data and let signature to be fetched as needed. that's the reason why we don't specify checksum for signature fetches.

I experienced the hard fail -> and it seems we need to fix it.

@sfc-gh-ptabor sfc-gh-ptabor force-pushed the 20231215-sig-unstable-download branch from 53acd8f to 8ff356f Compare December 15, 2023 11:45
@thesayyn
Copy link
Collaborator

@sfc-gh-ptabor can you resolve conflicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants