Error compiling with latest nightly - asm syntax outdated

[dunnock]

Hi, I've got following error in my project https://github.com/tari-project/validator-node/runs/722688938#step:8:234 compiling with latest nightly with clear_on_drop:0.2.3 dependency:

error: legacy asm! syntax is no longer supported
##[error]  --> /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/clear_on_drop-0.2.3/src/hide.rs:38:17
   |
38 |                 asm!("" : : "r" (ptr as *mut u8) : "memory");
   |                 ----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |                 |
   |                 help: replace with: `llvm_asm!`

error: legacy asm! syntax is no longer supported
##[error]  --> /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/clear_on_drop-0.2.3/src/hide.rs:47:17
   |
47 |                 asm!("" : "=*m" (ptr) : "*0" (ptr));
   |                 ----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |                 |
   |                 help: replace with: `llvm_asm!`

[cesarb]

That is a strange one. Both asm!() are within a #[cfg(feature = "nightly")], so they should not break unless you set the nightly feature for this crate, but from what I could see you are not doing that. I triggered a CI run of this crate to see if after rust-lang/rust#70173 it breaks even if the asm!() is inside a #[cfg]'ed out block, but as you can see at https://travis-ci.org/github/cesarb/clear_on_drop/builds/693501576 it breaks only when the nightly feature is being used (as expected), and compiles fine without the nightly feature. I have no idea why your build is breaking, unless the dependency is coming from somewhere I didn't look, and that place is setting the nightly feature for this crate.

[dunnock]

That's strange indeed, from our side setting nightly version to nightly-2020-05-07 helped... And that can be reproduced from our project but not when directly building your lib:

❯ cargo +nightly-2020-05-07-x86_64-apple-darwin build
warning: unused variable: `asset_id`
  --> cli/src/commands/assets.rs:95:28
   |
95 |             Self::Tokens { asset_id } => {
   |                            ^^^^^^^^ help: try ignoring the field: `asset_id: _`
   |
   = note: `#[warn(unused_variables)]` on by default

warning: 1 warning emitted

    Finished dev [unoptimized + debuginfo] target(s) in 1.25s

❯ cargo +nightly-2020-05-30-x86_64-apple-darwin build
   Compiling proc-macro2 v1.0.17
   Compiling unicode-xid v0.2.0
...
error: legacy asm! syntax is no longer supported
   --> /Users/max/.cargo/registry/src/github.com-1ecc6299db9ec823/subtle-2.2.2/src/lib.rs:150:14
    |
150 |     unsafe { asm!("" : "=r"(input) : "0"(input) ) }
    |              ----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |              |
    |              help: replace with: `llvm_asm!`

error: aborting due to previous error

error: could not compile `subtle`.

To learn more, run the command again with --verbose.
warning: build failed, waiting for other jobs to finish...
error: build failed

prob something sneaked into latest nightlies

[cesarb]

I changed it to use llvm_asm! (unfortunately, the new asm! cannot be used due to rust-lang/rust#72965) and released 0.2.4, could you check if it it works for you, and if it does, close this issue?

[dunnock]

Hi @cesarb, many thanks that helped, it worked fine after updating! Closing this issue