Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: calltree speed up getalltypes #546

Merged
merged 4 commits into from
Dec 14, 2024

Conversation

lukecotter
Copy link
Contributor

Description

  • speed up getAllTypes for types filter by ~1000% (12x faster)
    ~421ms vs ~35ms for a 71MB log.
    ~1,240ms vs ~62ms for 100mb log

Type of change (check all applicable)

  • 🐛 Bug fix
  • ✨ New feature
  • ♻️ Refactor
  • ⚡ Performance Improvement
  • 📝 Documentation
  • 🔧 Chore
  • 💥 Breaking change

[optional] Any images / gifs / video

Related Tickets & Documents

Related Issue #
fixes #
resolves #
closes #

Added tests?

  • 👍 yes
  • 🙅 no, not needed
  • 🙋 no, I need help

Added to documentation?

  • 🔖 README.md
  • 🔖 CHANGELOG.md
  • 📖 help site
  • 🙅 not needed

[optional] Are there any post-deployment tasks we need to perform?

@lukecotter lukecotter marked this pull request as draft November 29, 2024 10:47
@lukecotter
Copy link
Contributor Author

Merge after the v1.16.0 bug fix release

@lukecotter lukecotter changed the title Perf calltree getalltypes perf: calltree speed up getalltypes Dec 3, 2024
@lcottercertinia lcottercertinia marked this pull request as ready for review December 14, 2024 00:55
@lcottercertinia lcottercertinia merged commit a5cde71 into certinia:main Dec 14, 2024
5 checks passed
@lukecotter lukecotter deleted the perf-calltree-getalltypes branch December 20, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants