Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix publish jobs #468

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

lukecotter
Copy link
Contributor

Description

The ovsx cli behaves differently when --packagePath is passed compared to vsce. It causes the package command in vsce to be called again and and extension vsix re created.

Type of change (check all applicable)

  • 🐛 Bug fix
  • ✨ New feature
  • ♻️ Refactor
  • ⚡ Performance Improvement
  • 📝 Documentation
  • 🔧 Chore
  • 💥 Breaking change

[optional] Any images / gifs / video

Related Tickets & Documents

Related Issue #
fixes #
resolves #
closes #

Added tests?

  • 👍 yes
  • 🙅 no, not needed
  • 🙋 no, I need help

Added to documentation?

  • 🔖 README.md
  • 🔖 CHANGELOG.md
  • 📖 help site
  • 🙅 not needed

[optional] Are there any post-deployment tasks we need to perform?

The ovsx cli behaves differently when --packagePath is passed compared to vsce.
It causes the package command in vsce to be called again and and extension vsix re created.
@lcottercertinia lcottercertinia merged commit 0502520 into certinia:main Dec 20, 2023
3 checks passed
@lukecotter lukecotter deleted the chore-fix-publish-jobs branch December 20, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants