perf: dynamically import apex-node + sfdx-auth-helper

This will create chunks and allow for the js to be loaded and parsed faster as the chunks will be parsed later.
certinia · Dec 15, 2023 · 61f354c · 61f354c
1 parent a752e67
commit 61f354c
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 23 deletions.
diff --git a/lana/src/salesforce/logs/GetLogFile.ts b/lana/src/salesforce/logs/GetLogFile.ts
@@ -1,15 +1,15 @@
 /*
  * Copyright (c) 2020 Certinia Inc. All rights reserved.
  */
-import { AuthHelper } from '@apexdevtools/sfdx-auth-helper';
-import { LogService } from '@salesforce/apex-node';
 
 export class GetLogFile {
   static async apply(wsPath: string, logDir: string, logId: string): Promise<void> {
+    const { AuthHelper } = await import('@apexdevtools/sfdx-auth-helper');
     const ah = await AuthHelper.instance(wsPath);
     const connection = await ah.connect(await ah.getDefaultUsername());
 
     if (connection) {
+      const { LogService } = await import('@salesforce/apex-node');
       await new LogService(connection).getLogs({ logId: logId, outputDir: logDir });
     }
     return new Promise((resolve) => resolve());

diff --git a/lana/src/salesforce/logs/GetLogFiles.ts b/lana/src/salesforce/logs/GetLogFiles.ts
@@ -1,15 +1,16 @@
 /*
  * Copyright (c) 2020 Certinia Inc. All rights reserved.
  */
-import { AuthHelper } from '@apexdevtools/sfdx-auth-helper';
-import { type LogRecord, LogService } from '@salesforce/apex-node';
+import { type LogRecord } from '@salesforce/apex-node';
 
 export class GetLogFiles {
   static async apply(wsPath: string): Promise<LogRecord[]> {
+    const { AuthHelper } = await import('@apexdevtools/sfdx-auth-helper');
     const ah = await AuthHelper.instance(wsPath);
     const connection = await ah.connect(await ah.getDefaultUsername());
 
     if (connection) {
+      const { LogService } = await import('@salesforce/apex-node');
       return new LogService(connection).getLogRecords();
     }
     return [];

diff --git a/package.json b/package.json
@@ -31,7 +31,7 @@
     "bump-prerelease": "node ./scripts/pre-release.js",
     "preinstall": "npx only-allow pnpm",
     "build": "NODE_ENV=production pnpm run build:dev",
-    "build:dev": "concurrently -r -g 'rm -rf lana/out && rollup -c rollup.config.mjs' 'tsc --noemit --skipLibCheck -p log-viewer/tsconfig.json' 'tsc --noemit --skipLibCheck -p lana/tsconfig.json'",
+    "build:dev": "rm -rf lana/out && concurrently -r -g 'rollup -c rollup.config.mjs' 'tsc --noemit --skipLibCheck -p log-viewer/tsconfig.json' 'tsc --noemit --skipLibCheck -p lana/tsconfig.json'",
     "watch": "rm -rf lana/out && rollup -w -c rollup.config.mjs",
     "prepare": "husky install",
     "lint": "concurrently -r -g 'eslint . --ext ts' 'prettier --cache **/*.{ts,css,md,scss} --check' 'tsc --noemit --skipLibCheck -p log-viewer/tsconfig.json' 'tsc --noemit --skipLibCheck -p lana/tsconfig.json'",

diff --git a/rollup.config.mjs b/rollup.config.mjs
@@ -20,7 +20,8 @@ export default [
     input: './lana/src/Main.ts',
     output: {
       format: 'cjs',
-      file: './lana/out/Main.js',
+      dir: './lana/out',
+      chunkFileNames: '[name].js',
       sourcemap: false,
     },
     external: ['vscode'],
@@ -87,23 +88,23 @@ export default [
             dest: './log-viewer/out/index.html',
             minifierOptions: production
               ? {
-                    collapseWhitespace: true,
-                    html5: true,
-                    includeAutoGeneratedTags: false,
-                    minifyCSS: true,
-                    preventAttributesEscaping: true,
-                    processConditionalComments: true,
-                    removeAttributeQuotes: false,
-                    removeComments: true,
-                    removeEmptyAttributes: false,
-                    removeOptionalTags: true,
-                    removeRedundantAttributes: true,
-                    removeScriptTypeAttributes: true,
-                    removeStyleLinkTypeAttributes: true,
-                    sortAttributes: true,
-                    sortClassName: true,
-                    trimCustomFragments: true,
-                    useShortDoctype: true,
+                  collapseWhitespace: true,
+                  html5: true,
+                  includeAutoGeneratedTags: false,
+                  minifyCSS: true,
+                  preventAttributesEscaping: true,
+                  processConditionalComments: true,
+                  removeAttributeQuotes: false,
+                  removeComments: true,
+                  removeEmptyAttributes: false,
+                  removeOptionalTags: true,
+                  removeRedundantAttributes: true,
+                  removeScriptTypeAttributes: true,
+                  removeStyleLinkTypeAttributes: true,
+                  sortAttributes: true,
+                  sortClassName: true,
+                  trimCustomFragments: true,
+                  useShortDoctype: true,
                 }
               : {},
           },